accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-2552) Check for usage of FileSystem.get(Configuration)
Date Wed, 26 Mar 2014 00:03:16 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-2552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13947363#comment-13947363
] 

Josh Elser commented on ACCUMULO-2552:
--------------------------------------

Found the following (potential) issues:

1. Defaults to fs.defaultFS/fs.default.name for FileSystem. Should use FileSystem from the
Path instead of pulling the default. I think this has the potential to throw an error out
of Hadoop about using the "Wrong FS"
./core/src/main/java/org/apache/accumulo/core/file/rfile/SplitLarge.java:56:    FileSystem
fs = FileSystem.get(conf);

2. Just remove the getAndWrap method since it doesn't appear to be used anywhere?
./server/base/src/main/java/org/apache/accumulo/server/trace/TraceFileSystem.java:815:   
return wrap(FileSystem.get(conf));

3. Pulls the default filesystem and expects files to be located on it. Likely not of concern
because the class itself isn't "generally" recommended.
./server/base/src/main/java/org/apache/accumulo/server/util/AddFilesWithMissingEntries.java:68:
   final FileSystem fs = FileSystem.get(conf);

4. Log message about the URI being used to find the instance_id is no longer accurate
./server/base/src/main/java/org/apache/accumulo/server/util/ZooKeeperMain.java:43:    FileSystem
fs = FileSystem.get(CachedConfiguration.getInstance());

> Check for usage of FileSystem.get(Configuration)
> ------------------------------------------------
>
>                 Key: ACCUMULO-2552
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2552
>             Project: Accumulo
>          Issue Type: Task
>            Reporter: Mike Drob
>            Assignee: Josh Elser
>            Priority: Blocker
>             Fix For: 1.6.0
>
>
> There are still some places in the code that have not been updated to use the Volume
implementations, and without those updates will likely not work in 1.6
> One such place is the {{o.a.a.core.file.rfile.SplitLarge}} utility. There may be others.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message