accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mike Drob (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-2532) FileUtil expects instance.dfs.dir in tmpDir path
Date Wed, 26 Mar 2014 12:39:15 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-2532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13947861#comment-13947861
] 

Mike Drob commented on ACCUMULO-2532:
-------------------------------------

Is there a particular reason you went with the following pattern:
{code}
File dfsDir = Files.createTempDir();
   
try {
  // stuff
} finally {
  FileUtils.deleteQuietly(dfsDir);
}
{code}
Instead of using {{@Before}} and {{@After}} methods?

> FileUtil expects instance.dfs.dir in tmpDir path
> ------------------------------------------------
>
>                 Key: ACCUMULO-2532
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2532
>             Project: Accumulo
>          Issue Type: Sub-task
>          Components: master, tserver
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>            Priority: Critical
>             Fix For: 1.6.0
>
>
> FileUtil#cleanupIndexOp(AccumuloConfiguration, Path, VolumeManager, ArrayList) checks
that the temporary directory Path it was given ends with the value of instance.dfs.dir and
"/tmp".
> instance.dfs.dir is no longer appended to each volume, so this check is likely wrong
and result in tmp directories not being cleaned up properly.
> This also necessitates a unit test to prevent from happening again.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message