accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey (JIRA)" <j...@apache.org>
Subject [jira] [Created] (ACCUMULO-2511) Value allows equals(byte[])
Date Thu, 20 Mar 2014 20:03:47 GMT
Sean Busbey created ACCUMULO-2511:
-------------------------------------

             Summary: Value allows equals(byte[])
                 Key: ACCUMULO-2511
                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2511
             Project: Accumulo
          Issue Type: Improvement
            Reporter: Sean Busbey


Right now the equals(Object) method for Value is

{noformat}
 @Override
  public boolean equals(Object right_obj) {
    if (right_obj instanceof byte[]) {
      return compareTo((byte[]) right_obj) == 0;
    }
    if (right_obj instanceof Value) {
      return compareTo(right_obj) == 0;
    }
    return false;
  }

{noformat}

It's in a section that says it was copied from BytesWritable.

If we're not using this optimization anywhere, I'd rather remove it since it is non-intuitive.

If we are using it, I'd prefer we move it into something other than the general equals



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message