accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-2447) Shell#printHelp should use the ConsoleReader to print
Date Mon, 10 Mar 2014 22:16:53 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-2447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13926327#comment-13926327
] 

ASF subversion and git services commented on ACCUMULO-2447:
-----------------------------------------------------------

Commit e13c27331a42d55408427f18d97b285372f92a47 in accumulo's branch refs/heads/master from
[~elserj]
[ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=e13c273 ]

ACCUMULO-2447 Always set PrintWriter on Shell and don't print to stderr.

While we don't have access to the printwriter/outputstream from the jline
ConsoleReader, we can force the user to pass in one (or just make one for
stdout). This will allow unit tests to correctly squash all output into
a bytearray (or similar) instead of having to redirect stderr too (which
would have other repercussions).


> Shell#printHelp should use the ConsoleReader to print
> -----------------------------------------------------
>
>                 Key: ACCUMULO-2447
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2447
>             Project: Accumulo
>          Issue Type: Bug
>          Components: shell, test
>    Affects Versions: 1.5.1
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>            Priority: Minor
>             Fix For: 1.5.2, 1.6.0
>
>
> In debugging ShellServerTest, there was a ton of garbage on the console from the Help
command. In tracking this down, there's a method on Shell that always makes its own PrintWriter
to System.err.
> Then, optionally, it will print the same message to the OutputStream that the ConsoleReader
has. I'm not sure if there's a reason that we always need to print to System.err



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message