accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christopher Tubbs (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-2423) Converge Shell scripts on single implementation
Date Wed, 05 Mar 2014 17:28:42 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-2423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13921065#comment-13921065
] 

Christopher Tubbs commented on ACCUMULO-2423:
---------------------------------------------

I'm not sure I see the benefit of \[\[...]] over \[...], as a standard, because I think that
whatever works is fine. \[\[...]] is more flexible, so that's fine, but I'm not sure it warrants
standardizing on it. This does presume bash, so just to be clear, bash is a dependency of
this suggestion. I don't have a problem with it, per se, I just don't see much value in doing
it.

As for == over = as a standard, I actually dislike that. It looks incorrect, because of the
precedent, and only works with \[\[...]]. If we were to standardize on one over the other,
I say use the single =. Granted, I understand this looks like an assignment to those unfamiliar
with shell scripting, but I think it's better to teach people to avoid ==, because of its
limitations. It's just a better habit to use =, I think, when writing shell scripts.

> Converge Shell scripts on single implementation
> -----------------------------------------------
>
>                 Key: ACCUMULO-2423
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2423
>             Project: Accumulo
>          Issue Type: Improvement
>    Affects Versions: 1.6.0
>            Reporter: Mike Drob
>         Attachments: ACCUMULO-2423.v1.patch.txt
>
>
> Do we want to have a stated dependency on a particular shell? Most of our scripts explicitly
use bash, but some use sh. Most scripts invoke {{#\!/usr/bin/env bash}} but some do {{#\!/bin/bash}}
or other crazy things.
> I don't have a particular preference which way we go, but I'd like to see us standardize
one way or the other.
> If we use {{/bin/sh}}, then we can run everything through the [checkbashisms|https://wiki.ubuntu.com/DashAsBinSh#I_am_a_developer._How_can_I_avoid_this_problem_in_future.3F]
script (also available for other distros)
> If we go the other way, and switch everything to bash, then we can run them through {{ksh
-n}} for deprecation warnings. I know that's a different shell, but they're still moderately
useful.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message