Return-Path: 
 <notifications-return-16525-apmail-accumulo-notifications-archive=accumulo.apache.org@accumulo.apache.org>
X-Original-To: apmail-accumulo-notifications-archive@minotaur.apache.org
Delivered-To: apmail-accumulo-notifications-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 51BCD109D5
	for <apmail-accumulo-notifications-archive@minotaur.apache.org>;
 Wed, 12 Feb 2014 01:54:24 +0000 (UTC)
Received: (qmail 66158 invoked by uid 500); 12 Feb 2014 01:54:23 -0000
Delivered-To: apmail-accumulo-notifications-archive@accumulo.apache.org
Received: (qmail 66119 invoked by uid 500); 12 Feb 2014 01:54:22 -0000
Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:notifications-help@accumulo.apache.org>
List-Unsubscribe: <mailto:notifications-unsubscribe@accumulo.apache.org>
List-Post: <mailto:notifications@accumulo.apache.org>
List-Id: <notifications.accumulo.apache.org>
Reply-To: jira@apache.org
Delivered-To: mailing list notifications@accumulo.apache.org
Received: (qmail 65971 invoked by uid 99); 12 Feb 2014 01:54:21 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Feb 2014 01:54:21 +0000
Date: Wed, 12 Feb 2014 01:54:21 +0000 (UTC)
From: "Josh Elser (JIRA)" <jira@apache.org>
To: notifications@accumulo.apache.org
Message-ID: <JIRA.12694642.1392166937241.28092.1392170061386@arcas>
In-Reply-To: <JIRA.12694642.1392166937241@arcas>
References: <JIRA.12694642.1392166937241@arcas>
Subject: [jira] [Commented] (ACCUMULO-2354) Master does not close
 TabletServerBatchReader
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/ACCUMULO-2354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13898654#comment-13898654 ] 

Josh Elser commented on ACCUMULO-2354:
--------------------------------------

Why not just return ScannerBase? That has a close() method common to both the Scanner and BatchScanner impls.

> Master does not close TabletServerBatchReader
> ---------------------------------------------
>
>                 Key: ACCUMULO-2354
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2354
>             Project: Accumulo
>          Issue Type: Bug
>          Components: master
>         Environment: cdh4.5.0, accumulo f9a196f
>            Reporter: Mike Drob
>             Fix For: 1.6.0
>
>
> Saw the following in the Master logs:
> {noformat}
> 2014-02-11 16:55:10,820 [impl.TabletServerBatchReader] WARN : TabletServerBatchReader not shutdown; did you forget to call close()?
> java.lang.Throwable
>         at org.apache.accumulo.core.client.impl.TabletServerBatchReader.<init>(TabletServerBatchReader.java:69)
>         at org.apache.accumulo.core.client.impl.ConnectorImpl.createBatchScanner(ConnectorImpl.java:98)
>         at org.apache.accumulo.server.master.state.MetaDataTableScanner.<init>(MetaDataTableScanner.java:63)
>         at org.apache.accumulo.server.master.state.MetaDataTableScanner.<init>(MetaDataTableScanner.java:56)
>         at org.apache.accumulo.server.master.state.MetaDataStateStore.iterator(MetaDataStateStore.java:70)
>         at org.apache.accumulo.master.TabletGroupWatcher.run(TabletGroupWatcher.java:148)
> {noformat}
> This happened shortly after a tablet server had died and it's tablets were in the process of being recovered elsewhere.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)