Return-Path: X-Original-To: apmail-accumulo-notifications-archive@minotaur.apache.org Delivered-To: apmail-accumulo-notifications-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6DBD9107E9 for ; Wed, 5 Feb 2014 09:16:22 +0000 (UTC) Received: (qmail 14813 invoked by uid 500); 5 Feb 2014 09:16:21 -0000 Delivered-To: apmail-accumulo-notifications-archive@accumulo.apache.org Received: (qmail 14763 invoked by uid 500); 5 Feb 2014 09:16:20 -0000 Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@apache.org Delivered-To: mailing list notifications@accumulo.apache.org Received: (qmail 14619 invoked by uid 99); 5 Feb 2014 09:16:09 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Feb 2014 09:16:09 +0000 Date: Wed, 5 Feb 2014 09:16:09 +0000 (UTC) From: "Vikram Srivastava (JIRA)" To: notifications@accumulo.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (ACCUMULO-2325) Avoid repeated checking in addViolation in NumericValueConstraint and AlphaNumKeyContraint MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ACCUMULO-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vikram Srivastava updated ACCUMULO-2325: ---------------------------------------- Attachment: ACCUMULO-2325.v1.patch.txt Attached patch against master. > Avoid repeated checking in addViolation in NumericValueConstraint and AlphaNumKeyContraint > ------------------------------------------------------------------------------------------ > > Key: ACCUMULO-2325 > URL: https://issues.apache.org/jira/browse/ACCUMULO-2325 > Project: Accumulo > Issue Type: Bug > Affects Versions: 1.7.0 > Reporter: Vikram Srivastava > Assignee: Vikram Srivastava > Priority: Minor > Fix For: 1.7.0 > > Attachments: ACCUMULO-2325.v1.patch.txt > > > addViolation is very verbose and does check for null on every violation. Instead we can initialize violations as non-null just return null from check if the list is empty. -- This message was sent by Atlassian JIRA (v6.1.5#6160)