accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mike Drob (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-2418) replace empty loops in tests with simple count method
Date Thu, 27 Feb 2014 17:23:19 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-2418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13914757#comment-13914757
] 

Mike Drob commented on ACCUMULO-2418:
-------------------------------------

minor nit: you dropped the fail message from {{NoMutationRecoveryIT.java}} when it could have
been part of the assert.
{noformat}
-    for (@SuppressWarnings("unused") Entry<Key, Value> refs : getLogRefs(conn, MetadataTable.NAME))
{
-      fail("should not have any refs");
-    }
+    assertEquals(0, FunctionalTestUtils.count(getLogRefs(conn, MetadataTable.NAME)));
{noformat}

> replace empty loops in tests with simple count method
> -----------------------------------------------------
>
>                 Key: ACCUMULO-2418
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2418
>             Project: Accumulo
>          Issue Type: Bug
>          Components: test
>            Reporter: Eric Newton
>            Assignee: Eric Newton
>            Priority: Trivial
>             Fix For: 1.6.0
>
>
> While fixing ACCUMULO-2405, I created a simple method to eliminate a loop.  There are
many tests that could use this method.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message