accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-2390) TraceProxy.trace should not throw InvocationTargetException
Date Mon, 24 Feb 2014 17:34:20 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-2390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13910551#comment-13910551
] 

ASF subversion and git services commented on ACCUMULO-2390:
-----------------------------------------------------------

Commit 2829426618b6e7d1487a4c88dd7b09186b9898d5 in accumulo's branch refs/heads/1.6.0-SNAPSHOT
from [~mdrob@cloudera.com]
[ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=2829426 ]

ACCUMULO-2390 InvocationTargetEx in TraceProxy

Handle InvocationTargetException specifically in TraceProxy, instead
of letting it get propogated up the call stack. In some cases this is
very bad as it turned into an UndeclaredThrowableException and made
debugging more difficult than necessary.

Added unit test to verify behaviour.


> TraceProxy.trace should not throw InvocationTargetException
> -----------------------------------------------------------
>
>                 Key: ACCUMULO-2390
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2390
>             Project: Accumulo
>          Issue Type: Bug
>          Components: trace
>    Affects Versions: 1.4.4, 1.5.0
>            Reporter: Mike Drob
>            Assignee: Mike Drob
>             Fix For: 1.4.5, 1.6.0, 1.5.2
>
>
> In {{TraceProxy.trace}} there is the following code snippet:
> {code}
>         try {
>           return method.invoke(instance, args);
>         } catch (Throwable ex) {
>           ex.printStackTrace();
>           throw ex;
>         }
> {code}
> When this is an InvocationTargetException, it can really mess with the calling code's
exception handling logic.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message