accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-2373) Daemons should be able to log if log4j.properties specifies sufficient logging
Date Wed, 19 Feb 2014 01:04:23 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-2373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13904921#comment-13904921
] 

Josh Elser commented on ACCUMULO-2373:
--------------------------------------

I just tried testing out a change that wouldn't reload the log4j configuration when the generic_logger.xml
file isn't present.

The problem is that the code is rather error prone and introduces its own set of oddities
(e.g. if generic_logger.xml was deleted, suddenly logging continues all on its own).

But still, I tried this out with the log4j.properties file you attached here, and opened a
shell. After trying to create a table which already existed, I got no output in my shell yet
the command failed. My shell output was redirected to the file specified in that log4j.properties.
That, in addition to the additional problems that are introduced in trying to make this edge
case do what you think it should make me more convinced that this is not a problem.

I would recommend that you create a ticket to revisit how logging is configured in Accumulo
to address your concerns about being more compatible with a wider breadth of log4j functionality.

> Daemons should be able to log if log4j.properties specifies sufficient logging
> ------------------------------------------------------------------------------
>
>                 Key: ACCUMULO-2373
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2373
>             Project: Accumulo
>          Issue Type: Bug
>            Reporter: Vikram Srivastava
>         Attachments: log4j.properties
>
>
> Before this commit:
> commit 0351d0d416df51f0b10d91acdc074dced36e40d4
> Author: Josh Elser <elserj@apache.org>
> Date:   Mon Feb 10 23:28:31 2014 -0500
>     ACCUMULO-2334 Remove ACCUMULO_LOG_HOST in favor of pull host and port log-forwarding
from zookeeper
> I was able to do logging with only log4j.properties. However, that doesn't work anymore.
All my daemons have this as the last line of their logs:
> {noformat}
> 2014-02-14 14:23:38,049 INFO org.apache.accumulo.server.Accumulo: Zookeeper connected
and initialized, attemping to talk to HDFS
> 2014-02-14 14:23:38,067 INFO org.apache.accumulo.server.watcher.MonitorLog4jWatcher:
Changing monitor log4j address to 10.20.93.170:4560
> 2014-02-14 14:23:38,067 INFO org.apache.accumulo.server.watcher.MonitorLog4jWatcher:
Enabled log-forwarding
> {noformat}
> Note that I don't use generic_logger.xml, and this wasn't a requirement for 1.4. But
now it seems there is no logging if *_logger.xml files are not present (as ACCUMULO-2349 has
also reported).



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message