accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Henrique Mendonça (JIRA) <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-2358) Issue with character encoding of Success returned from Login using Thrift Proxy and NodeJS
Date Wed, 12 Feb 2014 18:57:21 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-2358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13899431#comment-13899431
] 

Henrique Mendonça commented on ACCUMULO-2358:
---------------------------------------------

Sorry I'm answering from the Thrift side and I'm sorry but I have no clue what are you guys
doing here. I have tracked down your .thrift file in github, which is bloody huge. I'd strongly
recommend you guys to use includes and/or service hierarchic, i.e. "extend" to divide the
logic and declarations. Please see https://thrift.apache.org/docs/idl/

Anyway, it looks like you guys are using binary parameters, which had a known bug on 0.9.1
You can apply https://issues.apache.org/jira/browse/THRIFT-1351 , switch to master or wait
a bit for 0.9.2
Thanks for reporting it anyways!

Cheers,
Henrique

> Issue with character encoding of Success returned from Login using Thrift Proxy and NodeJS
> ------------------------------------------------------------------------------------------
>
>                 Key: ACCUMULO-2358
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2358
>             Project: Accumulo
>          Issue Type: Bug
>          Components: client, proxy
>    Affects Versions: 1.5.0
>         Environment: CentOS 6.4, NodeJS 0.10.21, NPM thrift module 0.9.1
>            Reporter: Ryan Knowles
>            Priority: Minor
>
> I recently tried to connect to Accumulo through the Thrift proxy using NodeJS. 
> I was able to successfully send login information to Accumulo and receive back a success,
but when I tried to use this success to feed into other functions such as listTables I would
receive an Exception.  
> I traced this down to the AccumuloProxy.js file that was generated from the proxy.thrift
file.  In the AccumuloProxy_login_result.prototype.read function if the ftype == Thrift.Type.STRING
then this.success is set to input.readString().  During this readString function the toString
is called on the Buffer, but what is returned has characters that are not correctly encoded.
 I modified the AccumuloProxy_login_result.prototype.read to call readBinary instead and return
the Buffer as success.  I was then able to pass the Buffer into the other functions and correctly
get a result.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message