accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mike Drob (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-2354) Master does not close TabletServerBatchReader
Date Wed, 12 Feb 2014 01:36:19 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-2354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13898632#comment-13898632
] 

Mike Drob commented on ACCUMULO-2354:
-------------------------------------

Looking at the code makes me think that the message has nothing to do with the tablet server's
demise. I believe the problem is that {{org.apache.accumulo.server.master.state.MetaDataStateStore.iterator()}}
provides no way to close the Scanner that it creates because the return type is just {{Iterator<TabletLocationState>}}.
We _could_ change that to something like a [CloseableIterator|http://stackoverflow.com/a/17539843/370585]
but that seems like it might be overkill.

Anybody else have thoughts on this?

> Master does not close TabletServerBatchReader
> ---------------------------------------------
>
>                 Key: ACCUMULO-2354
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2354
>             Project: Accumulo
>          Issue Type: Bug
>          Components: master
>         Environment: cdh4.5.0, accumulo f9a196f
>            Reporter: Mike Drob
>             Fix For: 1.6.0
>
>
> Saw the following in the Master logs:
> {noformat}
> 2014-02-11 16:55:10,820 [impl.TabletServerBatchReader] WARN : TabletServerBatchReader
not shutdown; did you forget to call close()?
> java.lang.Throwable
>         at org.apache.accumulo.core.client.impl.TabletServerBatchReader.<init>(TabletServerBatchReader.java:69)
>         at org.apache.accumulo.core.client.impl.ConnectorImpl.createBatchScanner(ConnectorImpl.java:98)
>         at org.apache.accumulo.server.master.state.MetaDataTableScanner.<init>(MetaDataTableScanner.java:63)
>         at org.apache.accumulo.server.master.state.MetaDataTableScanner.<init>(MetaDataTableScanner.java:56)
>         at org.apache.accumulo.server.master.state.MetaDataStateStore.iterator(MetaDataStateStore.java:70)
>         at org.apache.accumulo.master.TabletGroupWatcher.run(TabletGroupWatcher.java:148)
> {noformat}
> This happened shortly after a tablet server had died and it's tablets were in the process
of being recovered elsewhere.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message