accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-2326) Simplify ConstraintViolationSummary.toString
Date Wed, 05 Feb 2014 17:34:11 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-2326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13892329#comment-13892329
] 

ASF subversion and git services commented on ACCUMULO-2326:
-----------------------------------------------------------

Commit fcc17fc0aa6f6a3a60de94786db02d7c4b68dfea in branch refs/heads/master from [~vickyuec]
[ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=fcc17fc ]

ACCUMULO-2326 Simplify ConstraintViolationSummary.toString and add unit test

Signed-off-by: Eric Newton <eric.newton@gmail.com>


> Simplify ConstraintViolationSummary.toString
> --------------------------------------------
>
>                 Key: ACCUMULO-2326
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2326
>             Project: Accumulo
>          Issue Type: Improvement
>    Affects Versions: 1.7.0
>            Reporter: Vikram Srivastava
>            Assignee: Vikram Srivastava
>             Fix For: 1.7.0
>
>         Attachments: ACCUMULO-2326.v1.patch.txt
>
>
> The method uses "first" unnecessarily. It never checks if it's true and keeps setting
it to false and checking if it is false immediately after. It can be simplified and made more
readable.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message