accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vikram Srivastava (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-2326) Simplify ConstraintViolationSummary.toString
Date Wed, 05 Feb 2014 09:48:11 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-2326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13891957#comment-13891957
] 

Vikram Srivastava commented on ACCUMULO-2326:
---------------------------------------------

Also verified that the unit test passes with and without the change in CVSummary.java.

> Simplify ConstraintViolationSummary.toString
> --------------------------------------------
>
>                 Key: ACCUMULO-2326
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2326
>             Project: Accumulo
>          Issue Type: Bug
>    Affects Versions: 1.7.0
>            Reporter: Vikram Srivastava
>            Assignee: Vikram Srivastava
>             Fix For: 1.7.0
>
>         Attachments: ACCUMULO-2326.v1.patch.txt
>
>
> The method uses "first" unnecessarily. It never checks if it's true and keeps setting
it to false and checking if it is false immediately after. It can be simplified and made more
readable.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message