accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christopher Tubbs (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-2310) Look into merging SimpleMacIT and COnfigurableMacIT
Date Fri, 07 Feb 2014 05:01:20 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13894201#comment-13894201
] 

Christopher Tubbs commented on ACCUMULO-2310:
---------------------------------------------

See ACCUMULO-1996 for an explanation of the differences in scope between the two.

In short, the point was that the Simple version didn't need to know that it was running on
MAC, but the Configurable one did, because it needed to test specific configuration/alterations
to MAC.

The Simple one, ideally, could be pointed to a different instance... like one that is instanted
in the pre-integration-test phase of the build lifecycle and shared for all SimpleMacITs.
Or, it could be configured to connect to an external full instance. The point was... the tests
should be written such that they don't care. I actually did have a pre-integration-test instance
running to run these tests against, but it broke with the forked integration tests and I haven't
spent the time to get it to work. That, and as explained in 1996, some changes were made that
broke the intended minimalist behavior of the Simple version and I haven't fixed those alterations.

> Look into merging SimpleMacIT and COnfigurableMacIT
> ---------------------------------------------------
>
>                 Key: ACCUMULO-2310
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2310
>             Project: Accumulo
>          Issue Type: Bug
>          Components: test
>            Reporter: John Vines
>             Fix For: 1.7.0
>
>
> These two frameworks for tests do very similar things but have their own implementations.
Most notably-
> Simple sets things up BeforeClass and tears down AfterClass whereas Configurable uses
Before and After
> Simple logs everything under it's own class name with a random identifier while Configurable
uses the actual test names.
> The naming scheme for configurable is vastly more useful, but at the penalty of having
per-test MACs instead of per class MAC. This may necessitate a different type of MAC testing
framework which makes it really easy to spin up your own (which I think is necessary in order
have the better file naming).



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message