accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-2021) Replace ArgumentChecker with Guava's Preconditions
Date Fri, 07 Feb 2014 16:32:19 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13894696#comment-13894696
] 

ASF subversion and git services commented on ACCUMULO-2021:
-----------------------------------------------------------

Commit b94e308e5dcfc4bd19c735e9d323ea90b3d7d54c in branch refs/heads/master from [~bhavanki]
[ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=b94e308 ]

ACCUMULO-2021 Replace ArgumentChecker with Guava Preconditions

The ArgumentChecker offers some of the same argument checks as the Preconditions class
in Guava. This commit eliminates ArgumentChecker and replaces its uses with calls to
Preconditions, particularly Preconditions.checkArgument(). The Validator class inside
ArgumentChecker was also promoted to a regular class with its own unit test.


> Replace ArgumentChecker with Guava's Preconditions
> --------------------------------------------------
>
>                 Key: ACCUMULO-2021
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2021
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: client
>            Reporter: Josh Elser
>            Assignee: Bill Havanki
>             Fix For: 1.7.0
>
>
> ArgumentChecker has some convenience methods to perform validation on variables provided
to methods to ensure that they meet certain requirements. ArgumentChecker works in that regard,
but lacks some helpfulness like allowing the caller to provide an error message.
> Guava's Preconditions class has a wide variety of methods that perform the same functionality
and already have the error message support built in. 



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message