accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-1376) Shell should verify before dropping user
Date Sat, 22 Feb 2014 02:35:21 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-1376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13909175#comment-13909175
] 

Josh Elser commented on ACCUMULO-1376:
--------------------------------------

[~chentecaliente], functionally, the patch changes look good. A couple of small things:

# What branch is this patch based on?
# Make sure you use (or follow) the [codestyle guidelines|http://accumulo.apache.org/source.html].
Most notably, 2spaces instead of a tab character.
# Could you add a test for this while you're making these changes? (1.5 ShellServerTest, 1.6.0+
ShellServerIT)

> Shell should verify before dropping user
> ----------------------------------------
>
>                 Key: ACCUMULO-1376
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-1376
>             Project: Accumulo
>          Issue Type: Bug
>          Components: shell
>    Affects Versions: 1.5.0
>            Reporter: John Vines
>            Assignee: Billie Rinaldi
>            Priority: Trivial
>              Labels: patch
>         Attachments: ACCUMULO-1376.patch
>
>
> The shell checks before you drop a table. It should probably do the same for users.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message