Return-Path: X-Original-To: apmail-accumulo-notifications-archive@minotaur.apache.org Delivered-To: apmail-accumulo-notifications-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4E13010B2C for ; Fri, 17 Jan 2014 16:46:21 +0000 (UTC) Received: (qmail 34133 invoked by uid 500); 17 Jan 2014 16:46:20 -0000 Delivered-To: apmail-accumulo-notifications-archive@accumulo.apache.org Received: (qmail 34070 invoked by uid 500); 17 Jan 2014 16:46:20 -0000 Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@apache.org Delivered-To: mailing list notifications@accumulo.apache.org Received: (qmail 34059 invoked by uid 99); 17 Jan 2014 16:46:19 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Jan 2014 16:46:19 +0000 Date: Fri, 17 Jan 2014 16:46:19 +0000 (UTC) From: "John Vines (JIRA)" To: notifications@accumulo.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ACCUMULO-2208) Unable to cleanly close log... MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ACCUMULO-2208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13874933#comment-13874933 ] John Vines commented on ACCUMULO-2208: -------------------------------------- FTR, the error I saw has been traced back to the work I've been doing in 1998. Not sure if we want better handling here though. > Unable to cleanly close log... > ------------------------------ > > Key: ACCUMULO-2208 > URL: https://issues.apache.org/jira/browse/ACCUMULO-2208 > Project: Accumulo > Issue Type: Bug > Components: tserver > Affects Versions: 1.5.0 > Reporter: John Vines > > I saw this once over 36 tserver/days, caused by an InvalidArgumentException, so odd occurrence. It was doing CI but before agitation started so it was a non issue, but it could be. The code around this is > {code}for (DfsLogger logger : loggers) { > try { > logger.close(); > } catch (DfsLogger.LogClosedException ex) { > // ignore > } catch (Throwable ex) { > log.error("Unable to cleanly close log " + logger.getFileName() + ": " + ex); > } > } > loggers.clear(); > logSizeEstimate.set(0);{code} > so it seems like it blindly powered forward. However, because of the frequency of syncs and such, even if there was agitation the odds of losing data are very minute, but I do believe their still there. > But because the log message just relies on error.toString, I didn't get the violating stack trace. At the bare minimum, the message should be updated to log the full stack trace. -- This message was sent by Atlassian JIRA (v6.1.5#6160)