Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: jira@apache.org
Date: Thu, 9 Jan 2014 00:54:50 +0000 (UTC)
From: "Eric Newton (JIRA)" <jira@apache.org>
To: notifications@accumulo.apache.org
Message-ID: <JIRA.12687962.1389222349957.65537.1389228890545@arcas>
In-Reply-To: <JIRA.12687962.1389222349957@arcas>
References: <JIRA.12687962.1389222349957@arcas>
Subject: [jira] [Commented] (ACCUMULO-2160) Run findbugs for 1.6
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/ACCUMULO-2160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13866140#comment-13866140 ] 

Eric Newton commented on ACCUMULO-2160:
---------------------------------------

Oh, I probably shouldn't have inlined abs in the examples.  It's too confusing.  Random.nextLong() can return Long.MIN_VALUE.  Math.abs(Long.MIN_VALUE) == Long.MIN_VALUE, which is still negative.  I should at least make the function return Long.MAX_VALUE or zero or something. 

I have tried to get the formatter to work for me, but for some reason it doesn't.  I'll spend some time on that.

Unfortunately, there's no immutable array type.  findbugs was not happy about keeping or returning refs to mutable arrays.  PasswordToken is still Destroyable, but it may have leaked the password, but that was already possible.

> Run findbugs for 1.6
> --------------------
>
>                 Key: ACCUMULO-2160
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2160
>             Project: Accumulo
>          Issue Type: Task
>            Reporter: Eric Newton
>            Assignee: Eric Newton
>             Fix For: 1.6.0
>
>


--
This message was sent by Atlassian JIRA
(v6.1.5#6160)