Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: jira@apache.org
Date: Thu, 9 Jan 2014 00:36:50 +0000 (UTC)
From: "Christopher Tubbs (JIRA)" <jira@apache.org>
To: notifications@accumulo.apache.org
Message-ID: <JIRA.12687962.1389222349957.65409.1389227810730@arcas>
In-Reply-To: <JIRA.12687962.1389222349957@arcas>
References: <JIRA.12687962.1389222349957@arcas>
Subject: [jira] [Commented] (ACCUMULO-2160) Run findbugs for 1.6
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/ACCUMULO-2160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13866112#comment-13866112 ] 

Christopher Tubbs commented on ACCUMULO-2160:
---------------------------------------------

Do we really want PasswordToken to return a copy on getPassword()? Will that violate it's "Destroyable"-ness in any way (maybe when it's overridden)? I'm not sure. Just want to make sure we're not doing something we don't want to do.

I also wonder how many of these changes can be represented as warnings in Eclipse (or your IDE of choosing) and whether we should make them standards. Eclipse may even support some of these things (like stripping redundant modifiers off interfaces) as save-actions.

Also, I noticed that many changes here added trailing whitespace (including indented blank lines).

In TestLruBlockCache (perhaps elsewhere also), it should probably have used JUnit's Assert.assertArrayEquals(), for more informative failure messages, rather than assertTrue(Arrays.equals())

It's curious that Math.abs was inline'd into the class. What's the reasoning for that in the examples?


> Run findbugs for 1.6
> --------------------
>
>                 Key: ACCUMULO-2160
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2160
>             Project: Accumulo
>          Issue Type: Task
>            Reporter: Eric Newton
>            Assignee: Eric Newton
>             Fix For: 1.6.0
>
>


--
This message was sent by Atlassian JIRA
(v6.1.5#6160)