accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Vines (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-2197) Building RPMs requires thrift profile to be active
Date Tue, 28 Jan 2014 04:21:38 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-2197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13883734#comment-13883734
] 

John Vines commented on ACCUMULO-2197:
--------------------------------------

I agree with Josh. We have a bunch of thrift generated classes sitting around already, I don't
see why things need to be different here. The thrift  protocol doesn't change much, and I
agree that we should put the burden of having thrift compiled on those who change the protocol,
not on every developer.

> Building RPMs requires thrift profile to be active
> --------------------------------------------------
>
>                 Key: ACCUMULO-2197
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2197
>             Project: Accumulo
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 1.5.0
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>             Fix For: 1.5.1, 1.6.0
>
>
> The generated sources (cpp, rb, py) for the proxy are only generated when the thrift
maven profile is activated. An RPM assembly expects these files to be present. Thus, the following
fails:
> {code}
> mvn package -Passemble,rpm -DskipTests
> {code}
> We should probably just include the gen-* variants under src/generated (or similar),
commit them to the repository, and let the thrift profile regenerate those files as necessary.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message