accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-2197) Building RPMs requires thrift profile to be active
Date Mon, 27 Jan 2014 17:31:41 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-2197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13882988#comment-13882988
] 

Josh Elser commented on ACCUMULO-2197:
--------------------------------------

bq. Technically speaking, it's probably a "package maintainer" responsibility

Ok, let me change my argument to something more accurate. *I* don't even want to have to deal
with Thrift (unless I'm actively changing something). If I want to build some RPMs for testing
Accumulo (as an Accumulo dev), I don't want to have to manage (2+ versions of) Thrift, and
personally, I don't think we should be pushing that on all Accumulo developers, as most changes
don't necessitate IDL changes.

We presently already have 103 thrift-generated classes in SCM (in 1.6.0), I (obviously) don't
see a big burden coming out of adding a few more from the proxy. We could potentially create
an RPM just for those thrift classes in the proxy module (and thus only activate when rpm
and thrift profiles are active) and remove it from the assemble module, but that also introduces
some unwanted complexity.

The other simple alternative is to just not bundle the gen-* source in an RPM.

> Building RPMs requires thrift profile to be active
> --------------------------------------------------
>
>                 Key: ACCUMULO-2197
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2197
>             Project: Accumulo
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 1.5.0
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>             Fix For: 1.5.1, 1.6.0
>
>
> The generated sources (cpp, rb, py) for the proxy are only generated when the thrift
maven profile is activated. An RPM assembly expects these files to be present. Thus, the following
fails:
> {code}
> mvn package -Passemble,rpm -DskipTests
> {code}
> We should probably just include the gen-* variants under src/generated (or similar),
commit them to the repository, and let the thrift profile regenerate those files as necessary.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message