accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <>
Subject [jira] [Commented] (ACCUMULO-2167) remove deprecation from ZooKeeperInstance(String, String) constructor
Date Mon, 13 Jan 2014 20:24:52 GMT


ASF subversion and git services commented on ACCUMULO-2167:

Commit e99275f9241c6297072d09d40eb6b2fbe3cc8ffa in branch refs/heads/master from [~keith_turner]
[;h=e99275f ]

ACCUMULO-2167 removed deprecation from ZooKeeperInstance(String, String) constructor

> remove deprecation from ZooKeeperInstance(String, String) constructor
> ---------------------------------------------------------------------
>                 Key: ACCUMULO-2167
>                 URL:
>             Project: Accumulo
>          Issue Type: Bug
>            Reporter: Keith Turner
>            Assignee: Keith Turner
>             Fix For: 1.6.0
> In 1.6.0-SNAPSHOT the ZooKeeperInstance(String, String) constructor was deprecated. 
It does not seem there is a compelling reason to do this.  Below are some reasons I can think
of not to do it.
>  * In 1.6.0 you still need to know an instance name and zookeepers to create a ZookeeperInstance
programmatically.  So its not like its reason for being is no longer valid.
>  * Its a nice conveince method for new code written against accumulo (its shorter than
{{new ClientConfiguration()..withInstance(instanceName).withZkHosts(zooKeepers)}}
>  * Most existing code using the API probably uses it.  Why annoy users unnecessarily?
>  * There is no maintenance burden for keeping the method
> I think all of the other constructors that were deprecated should stay deprecated.  Its
likely those constructors are not used, and if their functionality is needed then ClientConfiguration
can be used.

This message was sent by Atlassian JIRA

View raw message