accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Havanki (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-2160) Run findbugs for 1.6
Date Fri, 10 Jan 2014 21:03:51 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-2160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13868298#comment-13868298
] 

Bill Havanki commented on ACCUMULO-2160:
----------------------------------------

bq. Right, that was the findbugs complaint: that it wouldn't work for subclasses.

Yeah, it's that whole thing about whether {{equals()}} should rely on {{getClass()}} or {{instanceof}}.
I'm not judging which is better, and apparently Findbugs prefers {{instanceof}}; only that
this is a change of some significance. I think the only effect currently is this, which as
I said may or may not matter.

{noformat}
ConditionalWriterImpl.QCMutation qcm = something;  // extends ConditionalMutation
ConditionalMutation cm = (ConditionalMutation) something.clone();  // suppose clone works
assertTrue(cm.equals(qcm));  // used to be false
assertFalse(qcm.equals(cm));  // no symmetry
{noformat}

> Run findbugs for 1.6
> --------------------
>
>                 Key: ACCUMULO-2160
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2160
>             Project: Accumulo
>          Issue Type: Task
>            Reporter: Eric Newton
>            Assignee: Eric Newton
>             Fix For: 1.6.0
>
>




--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message