accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mike Drob (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-2136) Fate ctor invokes Thread.start
Date Fri, 10 Jan 2014 08:36:50 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-2136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13867625#comment-13867625
] 

Mike Drob commented on ACCUMULO-2136:
-------------------------------------

[~vickyuec] - How did you generate this patch? It looks like you used {{git diff}}, so I was
able to apply it using {{patch -p1}} but not {{git am}}. Can you create another patch using
{{git format-patch}} and upload it?

Can you add javadoc to the {{Fate}} constructor to hint to the user about the need to call
{{startTransactionRunners(int)}}?

Nit: There is trailing whitespace on Fate.java:145.

I'll assign the issue to you, thanks for taking this on!


> Fate ctor invokes Thread.start
> ------------------------------
>
>                 Key: ACCUMULO-2136
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2136
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: fate
>    Affects Versions: 1.6.0
>            Reporter: Eric Newton
>            Priority: Minor
>              Labels: PatchAvailable
>             Fix For: 1.7.0
>
>         Attachments: ACCUMULO-2136.patch
>
>
> Findbugs complains that the Fate constructor calls Thread.start.  The rationale: "This
is likely to be wrong if the class is ever extended/subclassed, since the thread will be started
before the subclass constructor is started."



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message