accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eric Newton (JIRA)" <j...@apache.org>
Subject [jira] [Created] (ACCUMULO-2131) while statement used as if statement
Date Fri, 03 Jan 2014 21:02:50 GMT
Eric Newton created ACCUMULO-2131:
-------------------------------------

             Summary: while statement used as if statement
                 Key: ACCUMULO-2131
                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2131
             Project: Accumulo
          Issue Type: Bug
          Components: tserver
            Reporter: Eric Newton
            Assignee: Keith Turner
            Priority: Trivial
             Fix For: 1.6.0


Going through PMD output, and this looks a little sketchy in SourceSwitchingIterator.java:

{noformat}
  private boolean switchSource() throws IOException {
    while (!source.isCurrent()) {
      source = source.getNewDataSource();
      iter = source.iterator();
      if (iflag != null)
        ((InterruptibleIterator) iter).setInterruptFlag(iflag);
      
      return true;
    }
    
    return false;
  }
{noformat}

I'm wondering if that "while" should be "if"



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message