accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Keith Turner (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-2128) Provide resource cleanup via static utility rather than Instance.close
Date Mon, 06 Jan 2014 20:39:53 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13863381#comment-13863381
] 

Keith Turner commented on ACCUMULO-2128:
----------------------------------------

335f693 is a partial revert of some of the changes made by other commits I am trying to revert.
 I don't want to revert 335f693 because that would bring back stuff we are trying to get rid
of. 379881e is the same situation.   When I tried to revert 379881e it brought back some calls
to instance.close() that were removed.  This was the first thing I tried and I threw it out
after reviewing the changes.   335f693 is a bigger change, I will review it to see if anything
needs to be done.

> Provide resource cleanup via static utility rather than Instance.close
> ----------------------------------------------------------------------
>
>                 Key: ACCUMULO-2128
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2128
>             Project: Accumulo
>          Issue Type: Bug
>          Components: client
>            Reporter: Sean Busbey
>            Assignee: Keith Turner
>            Priority: Blocker
>             Fix For: 1.4.5, 1.5.1, 1.6.0
>
>         Attachments: ACCUMULO-2128.1.patch.txt
>
>
> After [discussion about the current state of our code base and the need to properly clean
up global resources|http://mail-archives.apache.org/mod_mbox/accumulo-dev/201401.mbox/%3CCAGHyZ6JsKn6AuTpD5A6FFbgF1KY1fshGTvbe7rkhnVyRA5Sc%2Bw%40mail.gmail.com%3E],
consensus is that we need to provide a work around for now that doesn't rely on API changes.
> Later, when we refactor the client api we'll include proper lifecycle management, for
now we just need a global utility for unloading.
> This ticket needs to revert all commits from the Instance close work: ACCUMULO-1379,
ACCUMULO-1697, ACCUMULO-1858, ACCUMULO-2027, ACCUMULO-1889, and ACCUMULO-2105
> Also ACCUMULO-1923 can be closed as wontfix with a link here.
> Then we need a version of the solution outlined in ACCUMULO-2113 that does not rely on
reflection, if possible.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message