accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Keith Turner (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-2128) Provide resource cleanup via static utility rather than Instance.close
Date Mon, 06 Jan 2014 18:48:05 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13863226#comment-13863226
] 

Keith Turner commented on ACCUMULO-2128:
----------------------------------------

I have worked out a plan for doing this work.   My overall plan is to revert Instance.close()
in all branches.  After thats done I will add the static utility and merge it forward.  I
was going to revert in 1.4.5, add the utility in 1.4.5, and then merge all of that forward
but I think that could make resolving merge conflicts more complicated.  This would make it
harder to review conflicts related to the utility.     

The following commits occurred related to Instance.close() (merge related commits not included
in list).  The commits are in the order applied.

{noformat}
commits in 1.6.0-SNAPSHOT

379881e
975e8c0
674fa95
0d0bc46 
ada4180
79d686f
3f6c66e
7da1164

commits in 1.5.1-SNAPSHOT

975e8c0
0d0bc46
ada4180
79d686f

commits in 1.4.5-SNAPSHOT

975e8c0
0d0bc46
ada4180
79d686f
{noformat}

I am thinking of doing the following to revert and then add this utility.  I am breaking up
things for 1.6.0-SNAPSHOT in the hopes that all commits for 1.6.0 will leave things in a compiling
state.  Also hoping that breaking up the 1.6.0 revert/merge steps will make it more resilient
to concurrent commits by other developers.

 # revert 379881e 674fa95 in 1.6.0-SNAPSHOT
 # revert 975e8c0 0d0bc46 ada4180 79d686f in 1.4.5-SNAPSHOT
 # merge 1.4.5-SNAPSHOT to 1.5.1-SNAPSHOT
 # merge 1.5.1-SNAPSHOT to 1.6.0-SNAPSHOT
 # revert 3f6c66e 7da1164 in 1.6.0-SNAPSHOT
 # add utility to 1.4.5-SNAPSHOT
 # merge 1.4.5-SNAPSHOT to 1.5.1-SNAPSHOT
 # merge 1.5.1-SNAPSHOT to 1.6.0-SNAPSHOT
 # merge 1.6.0-SNAPSHOT to master

> Provide resource cleanup via static utility rather than Instance.close
> ----------------------------------------------------------------------
>
>                 Key: ACCUMULO-2128
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2128
>             Project: Accumulo
>          Issue Type: Bug
>          Components: client
>            Reporter: Sean Busbey
>            Assignee: Keith Turner
>            Priority: Blocker
>             Fix For: 1.4.5, 1.5.1, 1.6.0
>
>         Attachments: ACCUMULO-2128.1.patch.txt
>
>
> After [discussion about the current state of our code base and the need to properly clean
up global resources|http://mail-archives.apache.org/mod_mbox/accumulo-dev/201401.mbox/%3CCAGHyZ6JsKn6AuTpD5A6FFbgF1KY1fshGTvbe7rkhnVyRA5Sc%2Bw%40mail.gmail.com%3E],
consensus is that we need to provide a work around for now that doesn't rely on API changes.
> Later, when we refactor the client api we'll include proper lifecycle management, for
now we just need a global utility for unloading.
> This ticket needs to revert all commits from the Instance close work: ACCUMULO-1379,
ACCUMULO-1697, ACCUMULO-1858, ACCUMULO-2027, ACCUMULO-1889, and ACCUMULO-2105
> Also ACCUMULO-1923 can be closed as wontfix with a link here.
> Then we need a version of the solution outlined in ACCUMULO-2113 that does not rely on
reflection, if possible.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message