accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Keith Turner (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-2128) Provide resource cleanup via static utility rather than Instance.close
Date Fri, 03 Jan 2014 03:48:50 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13861170#comment-13861170
] 

Keith Turner commented on ACCUMULO-2128:
----------------------------------------

I created a non-reflection version of the utility.  Its in the following branch on github
which is based off 1.4.5-SNAPSHOT.   [~jaredwinick] I need to add your {{waitForZooKeeperClientThreads()}}
method in the CleanUp class I created.  I would like to get this in place before I proceed
with pushing to 1.4 and merging forward.   Can you create a patch that adds that method to
o.a.a.core.util.CleanUp in the following branch and attach it here?  That way the code will
be attributed to you and we can use it in Accumulo.  

https://github.com/keith-turner/accumulo/tree/ACCUMULO-2113



> Provide resource cleanup via static utility rather than Instance.close
> ----------------------------------------------------------------------
>
>                 Key: ACCUMULO-2128
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2128
>             Project: Accumulo
>          Issue Type: Bug
>          Components: client
>            Reporter: Sean Busbey
>            Assignee: Keith Turner
>            Priority: Blocker
>             Fix For: 1.4.5, 1.5.1, 1.6.0
>
>
> After [discussion about the current state of our code base and the need to properly clean
up global resources|http://mail-archives.apache.org/mod_mbox/accumulo-dev/201401.mbox/%3CCAGHyZ6JsKn6AuTpD5A6FFbgF1KY1fshGTvbe7rkhnVyRA5Sc%2Bw%40mail.gmail.com%3E],
consensus is that we need to provide a work around for now that doesn't rely on API changes.
> Later, when we refactor the client api we'll include proper lifecycle management, for
now we just need a global utility for unloading.
> This ticket needs to revert all commits from the Instance close work: ACCUMULO-1379,
ACCUMULO-1697, ACCUMULO-1858, ACCUMULO-2027, ACCUMULO-1889, and ACCUMULO-2105
> Also ACCUMULO-1923 can be closed as wontfix with a link here.
> Then we need a version of the solution outlined in ACCUMULO-2113 that does not rely on
reflection, if possible.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message