accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <>
Subject [jira] [Commented] (ACCUMULO-1984) Clean up Instance closing
Date Mon, 06 Jan 2014 22:37:52 GMT


ASF subversion and git services commented on ACCUMULO-1984:

Commit e946ba052c3fcce8d07815b9daf51bcdc3febbd3 in branch refs/heads/1.4.5-SNAPSHOT from [~keith_turner]
[;h=e946ba0 ]

ACCUMULO-1858 revert commits that added ZooKeeperInstance.close()

Revert "ACCUMULO-2027 Synchronized access to ZooKeeperInstance methods that mutated state"

This reverts commit 975e8c05e8d11f3848e6c800f4d2772026f6c3a3.

Revert "ACCUMULO-1984 Rework interruption for instance implementations."

This reverts commit 0d0bc4643a8680593e2cf5f828b7566c30fcb345.


Revert "ACCUMULO-1889 mark ZKI as closed once close() is called."

This reverts commit ada4180379d46297c1531cf8065de5030d12953d.

Revert "ACCUMULO-1858 Backport ZooKeeper clean up to 1.4 and 1.5."

This reverts commit 79d686faa1e477b9cbd80c6f833ece402050b490.


> Clean up Instance closing
> -------------------------
>                 Key: ACCUMULO-1984
>                 URL:
>             Project: Accumulo
>          Issue Type: Improvement
>            Reporter: Sean Busbey
>            Assignee: Bill Havanki
>            Priority: Blocker
>             Fix For: 1.4.5, 1.5.1, 1.6.0
>         Attachments: ACCUMULO-1984-1.4.patch
> Per discussion with [~ctubbsii] on ACCUMULO-1889:
> {quote}
> It seems to me that the best fix is to:
> * patch org.apache.accumulo.fate.zookeeper.ZooReader.close() to handle the ZooKeeper
close()'s InterruptedException properly with Thread.currentThread().interrupt()
> * stop propagating InterruptedException through the hierarchy of close() statements
> * drop the AccumuloException from the Instance.close() method signature and make Interface
extend instead (at the very least, drop the unnecessary AccumuloException
and make it AutoCloseable when we switch to JDK1.7; changing it to now would
ease that)
> * change that catch statement to catch RuntimeExceptions instead of InterruptedException
and rethrow them after fixing the counter
> {quote}
> Since this API is just being added, we should fix these things now before it gets published
in a release.

This message was sent by Atlassian JIRA

View raw message