accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-1944) Cobertura not working for functional tests in 1.5.x and earlier
Date Mon, 06 Jan 2014 19:42:52 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13863316#comment-13863316
] 

Josh Elser commented on ACCUMULO-1944:
--------------------------------------

I'm a little confused -- I'm looking at the 1.5.1-SNAPSHOT branch: 198b1abd9e81d1af55220bf22a0b4e6ec1d18048
and 8669b80f98da34da1b709d1ed4f14647cc1f952c seem to be duplicated by 950f144c8e3517053af704189f0fdfd769487dfd
and c23126a86d23566b154747d153bf489a09684c97, respectively. They seem to be the (about) the
same changes. I'm guessing that you applied both the 1.4 and the 1.5 patches?

In the future, you should just be applying the patch to the lowest-version branch which the
issue will be fixed in, and then merge it through. This will be a change for you in process
as you can now correctly resolve merge conflicts during the merge itself. I think [~busbey]
and [~mdrob] came up with an alternative plan that we might want to look into adopting that
would allow contributors to give that first patch, and then subsequent fixes for the merge
conflicts while avoiding the duplicate commits.

Having these duplicated commits is what we want to try to avoid as much as possible as tools
like git-bisect break down really quickly. Not a big deal that we need to do anything about
now, but I just wanted to make sure you're aware :)

> Cobertura not working for functional tests in 1.5.x and earlier
> ---------------------------------------------------------------
>
>                 Key: ACCUMULO-1944
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-1944
>             Project: Accumulo
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 1.4.4, 1.5.0
>            Reporter: Bill Havanki
>            Assignee: Bill Havanki
>              Labels: cobertura, testing
>             Fix For: 1.4.5, 1.5.1
>
>         Attachments: ACCUMULO-1944-1.4.patch, ACCUMULO-1944-1.4.v2.patch, ACCUMULO-1944-1.5.patch,
ACCUMULO-1944-1.5.v2.patch
>
>
> The -C argument to test/system/auto/run.py should enable running instrumented functional
tests to analyze coverage using Cobertura. The capability is not functional; code is not instrumented
even when Cobertura is available, and tests are not run with the instrumented code.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message