Return-Path: X-Original-To: apmail-accumulo-notifications-archive@minotaur.apache.org Delivered-To: apmail-accumulo-notifications-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5811310C66 for ; Thu, 5 Dec 2013 18:38:36 +0000 (UTC) Received: (qmail 23984 invoked by uid 500); 5 Dec 2013 18:38:36 -0000 Delivered-To: apmail-accumulo-notifications-archive@accumulo.apache.org Received: (qmail 23929 invoked by uid 500); 5 Dec 2013 18:38:36 -0000 Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@apache.org Delivered-To: mailing list notifications@accumulo.apache.org Received: (qmail 23920 invoked by uid 99); 5 Dec 2013 18:38:36 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Dec 2013 18:38:36 +0000 Date: Thu, 5 Dec 2013 18:38:36 +0000 (UTC) From: "Keith Turner (JIRA)" To: notifications@accumulo.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ACCUMULO-1958) Range constructor lacks key checks, should be non-public MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ACCUMULO-1958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13840386#comment-13840386 ] Keith Turner commented on ACCUMULO-1958: ---------------------------------------- Since its public it would first need to be deprecated in 1.6.0 and then the visibility could be changed in a later release. > Range constructor lacks key checks, should be non-public > -------------------------------------------------------- > > Key: ACCUMULO-1958 > URL: https://issues.apache.org/jira/browse/ACCUMULO-1958 > Project: Accumulo > Issue Type: Bug > Affects Versions: 1.4.0 > Reporter: Bill Havanki > Fix For: 1.7.0 > > > This ticket pertains to the Range class constructor with the following signature: > {noformat} > public Range(Key, Key, boolean, boolean, boolean, boolean) > {noformat} > The constructor does not check that the start key is before the end key, like every other constructor in the class. Since the constructor is public, this makes it possible for a caller to create invalid ranges. > The constructor is used by other constructors that take in existing range objects, where the key check has implicitly been done, and so it would make sense to skip the check in this one, but then the constructor visibility should be at least protected. -- This message was sent by Atlassian JIRA (v6.1#6144)