Return-Path: X-Original-To: apmail-accumulo-notifications-archive@minotaur.apache.org Delivered-To: apmail-accumulo-notifications-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D03B4101FE for ; Mon, 2 Dec 2013 19:48:36 +0000 (UTC) Received: (qmail 41497 invoked by uid 500); 2 Dec 2013 19:48:36 -0000 Delivered-To: apmail-accumulo-notifications-archive@accumulo.apache.org Received: (qmail 41460 invoked by uid 500); 2 Dec 2013 19:48:36 -0000 Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@apache.org Delivered-To: mailing list notifications@accumulo.apache.org Received: (qmail 41411 invoked by uid 99); 2 Dec 2013 19:48:36 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Dec 2013 19:48:36 +0000 Date: Mon, 2 Dec 2013 19:48:36 +0000 (UTC) From: "Josh Elser (JIRA)" To: notifications@accumulo.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ACCUMULO-1947) dfs.datanode.synconclose check is lacking MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ACCUMULO-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13836836#comment-13836836 ] Josh Elser commented on ACCUMULO-1947: -------------------------------------- Looks like the current check would incorrectly not warn users on hadoop-1.1 and 1.2 (the CreateFlag class does not exist, yet the option for DFS_DATANODE_SYNCONCLOSE does exist). > dfs.datanode.synconclose check is lacking > ----------------------------------------- > > Key: ACCUMULO-1947 > URL: https://issues.apache.org/jira/browse/ACCUMULO-1947 > Project: Accumulo > Issue Type: Bug > Reporter: Josh Elser > Assignee: Josh Elser > Priority: Blocker > Fix For: 1.5.1, 1.6.0 > > > The dfs configuration checks we now perform to support hdfs WALs includes a check for dfs.datanode.synconclose which informs the datanode to flush to disk when a file is closed instead of lazily writing the block (very important in the case of power failure). > Looking at the actual check, it performs reflection on a CreateFlag class. In Apache Hadoop 1.2.1, this class doesn't exist yet the option for dfs.datanode.synconclose does exist. We should likely just reflect on the constant DFSConfigKeys.DFS_DATANODE_SYNCONCLOSE_KEY or DFSConfigKeys.DFS_DATANODE_SYNCONCLOSE_DEFAULT to determine if that option is present. -- This message was sent by Atlassian JIRA (v6.1#6144)