Return-Path: X-Original-To: apmail-accumulo-notifications-archive@minotaur.apache.org Delivered-To: apmail-accumulo-notifications-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1BE611020F for ; Tue, 24 Dec 2013 00:29:51 +0000 (UTC) Received: (qmail 92381 invoked by uid 500); 24 Dec 2013 00:29:50 -0000 Delivered-To: apmail-accumulo-notifications-archive@accumulo.apache.org Received: (qmail 92321 invoked by uid 500); 24 Dec 2013 00:29:50 -0000 Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@apache.org Delivered-To: mailing list notifications@accumulo.apache.org Received: (qmail 92239 invoked by uid 99); 24 Dec 2013 00:29:50 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Dec 2013 00:29:50 +0000 Date: Tue, 24 Dec 2013 00:29:50 +0000 (UTC) From: "Ed Coleman (JIRA)" To: notifications@accumulo.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ACCUMULO-1910) Add source to jar files used for testing MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ACCUMULO-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13856044#comment-13856044 ] Ed Coleman commented on ACCUMULO-1910: -------------------------------------- I have no problem with just putting the jars into a patch. However, are there any issues with the manifest? Maven seems to insist that some of my info leak in - no problem with that if everyone is okay with it. With the current patch, it could be built on the jenkis server and then have only accumulo build artifacts. - (Seems cleaner to me.) Alternately, I could modify the build on my end, but sometimes it seems than me and maven are not the best of friends (i.e. suggestions more than welcome,) Or I could ditch maven and just jar cvf ... as long as no one wants to replicate the build... > Add source to jar files used for testing > ---------------------------------------- > > Key: ACCUMULO-1910 > URL: https://issues.apache.org/jira/browse/ACCUMULO-1910 > Project: Accumulo > Issue Type: Task > Components: test > Affects Versions: 1.4.4, 1.5.0 > Reporter: Josh Elser > Assignee: Ed Coleman > Labels: newbie > Fix For: 1.4.5, 1.5.1, 1.6.0 > > Attachments: ACCUMULO-1910-1.4.5.patch > > > Some of the jars we include for testing purposes have the source included. Some do not. > It would be nice to make sure that we included the source for all of these jars, not just the class files. > Jars in 1.4 with no source > * ./src/start/src/test/resources/ClassLoaderTestA/Test.jar > * ./src/start/src/test/resources/ClassLoaderTestB/Test.jar > * ./src/start/src/test/resources/ClassLoaderTestC/Test.jar > * ./src/start/target/test-classes/ClassLoaderTestA/Test.jar > * ./src/start/target/test-classes/ClassLoaderTestB/Test.jar > * ./src/start/target/test-classes/ClassLoaderTestC/Test.jar > * ./test/system/auto/TestCombinerX.jar > * ./test/system/auto/TestCombinerY.jar > Jars in 1.5 and 1.6 with no source: > * ./start/src/test/resources/ClassLoaderTestA/Test.jar > * ./start/src/test/resources/ClassLoaderTestB/Test.jar > * ./start/src/test/resources/ClassLoaderTestC/Test.jar > * ./start/src/test/resources/HelloWorld2.jar > * ./test/src/test/resources/FooConstraint.jar > * ./test/system/auto/TestCombinerX.jar > * ./test/system/auto/TestCombinerY.jar -- This message was sent by Atlassian JIRA (v6.1.5#6160)