accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jared Winick (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-2113) Verify that The Hammer approach to resource leak is a viable short term fix
Date Tue, 31 Dec 2013 07:48:52 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-2113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13859398#comment-13859398
] 

Jared Winick commented on ACCUMULO-2113:
----------------------------------------

This needs to be cleaned up a bit and posted as a patch but I wanted to make the code available
for review. To make my life easier I implemented the proposed ClientThreads within my test
web app at https://github.com/jaredwinick/accumulo-1858-test/blob/ACCUMULO-2113/src/main/java/org/apache/accumulo/core/util/ClientThreads.java
This current version is built and was tested against 1.4.3 but with minor refactoring should
apply to all versions. I will attach the graph from VisualVM that shows that it works just
like the other solution documented in ACCUMULO-1858. 

Since the implementation forcefully stops the ThriftTransportPool thread, I initially thought
I would try the same for the Zookeeper threads. It turned out that ZK is resilient and appeared
to handle the ThreadDeath and recover, so I opted for the more graceful shutdown of the ZooKeepers.

> Verify that The Hammer approach to resource leak is a viable short term fix
> ---------------------------------------------------------------------------
>
>                 Key: ACCUMULO-2113
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2113
>             Project: Accumulo
>          Issue Type: Task
>    Affects Versions: 1.4.5, 1.5.1, 1.6.0
>            Reporter: Sean Busbey
>            Assignee: Jared Winick
>            Priority: Blocker
>             Fix For: 1.4.5, 1.5.1, 1.6.0
>
>         Attachments: ACCUMULO-2113-ResourceGraph.png
>
>
> ACCUMULO-1858 contains a link to a test harness for verifying that we aren't leaking
resources in e.g. Tomcat.
> We need someone to take "The Hammer" approach [proposed by Keith|http://mail-archives.apache.org/mod_mbox/accumulo-dev/201312.mbox/%3CCAGUtCHrThjFW-u%2BJK%2BZYALB-qut2VNd5AH1Sb8o7UcQFUXM4xA%40mail.gmail.com%3E]
and verify that it successfully stops the leak.
> Afterwords, results should be linked to on the mailing list so we can come to consensus
on how to handle the API change for releases.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message