accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mike Drob (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-2064) Include Git SHA1 in artifacts
Date Sat, 28 Dec 2013 00:41:50 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-2064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13857869#comment-13857869
] 

Mike Drob commented on ACCUMULO-2064:
-------------------------------------

I think there is a difference between using it to support debugging SNAPSHOT builds (which
I do not care for) and providing additional information for QA builds (which I am a huge fan
of). Consider the case where you fire up a 24-hour ingest test, and it errors at the end with
something arcane. Meanwhile, other people have been adding code and your workspace copy no
longer matches what you deployed. Having the git commit may be helpful to track down a revision
from that point.

I'm not sure I understand your concern about not being able to reproduce source releases.
If the code is tagged, then it will always have the same commit id, which will always be the
same, every time you check it out. If anything, I believe it _adds_ to the release process,
as an extra verification in the artifact that shows "yes, this came from the source I claim."

> Include Git SHA1 in artifacts
> -----------------------------
>
>                 Key: ACCUMULO-2064
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2064
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: build
>            Reporter: Josh Elser
>            Assignee: Mike Drob
>            Priority: Minor
>             Fix For: 1.4.5, 1.5.1, 1.6.0
>
>
> After building a SNAPSHOT version of Accumulo, the Git commit ID it was built from is
lost in the wind the next time you update you copy of the repo.
> It would be nice to include the SHA1 in the the MANIFEST.MF. I've done this before, and
I remember it to be rather easy in the end, but I don't remember how off the top of my head.
> This would be very useful when running Accumulo's distributed tests during at the end
of a release cycle to rule out the possibility of running into a bug that was already fixed.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message