accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-2010) Remove resource leak warnings
Date Fri, 13 Dec 2013 23:02:07 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-2010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13848036#comment-13848036
] 

ASF subversion and git services commented on ACCUMULO-2010:
-----------------------------------------------------------

Commit 335f693a4045d2c2501e2ed6ece0493734093143 in branch refs/heads/master from [~ctubbsii]
[ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=335f693 ]

ACCUMULO-2010 Remove Closeable from interfaces

  This gets around compiler warnings about resource leaks. This reverts
  back to the old API semantics, where we are not advising that clients
  close Instance objects. If it is determined in the future that we
  should be advising clients to do this, and therefore want to
  re-introduce the Closeable interface to Instance and the ZooKeeper
  objects, it should be accompanied by changes that actually close these
  resources in our own code. We should not be recommending this without
  following our own recommendation, and adding Closeable to the
  interface is a recommendation to call the close method.

  Also clean up additional resource warnings.


> Remove resource leak warnings
> -----------------------------
>
>                 Key: ACCUMULO-2010
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2010
>             Project: Accumulo
>          Issue Type: Task
>            Reporter: Christopher Tubbs
>             Fix For: 1.4.5, 1.5.1, 1.6.0
>
>
> ACCUMULO-1984 introduced a lot of resource leak warnings, because it made Instance implement
Closeable. If we really want this instance to be Closeable, then we need to close it when
we're done with it, to set a good example for using the API, at the very least.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Mime
View raw message