accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Vines (JIRA)" <>
Subject [jira] [Resolved] (ACCUMULO-1987) Incorrect handling of auth byte sequences in TabletServer
Date Mon, 09 Dec 2013 16:22:07 GMT


John Vines resolved ACCUMULO-1987.

       Resolution: Fixed
    Fix Version/s: 1.6.0
         Assignee: Michael Allen

Patch applied. I corrected them, but please include the ticket number in the commit message
and make sure you have the patch use our formatting. Thanks!

> Incorrect handling of auth byte sequences in TabletServer
> ---------------------------------------------------------
>                 Key: ACCUMULO-1987
>                 URL:
>             Project: Accumulo
>          Issue Type: Bug
>    Affects Versions: 1.6.0
>            Reporter: Michael Allen
>            Assignee: Michael Allen
>             Fix For: 1.6.0
>         Attachments: Fixes-byte-buffer-copy-bug.patch
> In 667
> return security.userHasAuthorizations(credentials, Collections.<ByteBuffer> singletonList(ByteBuffer.wrap(****auth.getBackingArray()****)));
> (Emphasis mine obviously)
> That getBackingArray() will return the whole array even when the auth object has limits
set upon it.  That has the effect of passing labels to userHasAuthorization() that are incorrect.
 For instance, if your label expression has & and | in it, it will pass the entire string
as the label string, as opposed to just one part of it in certain parts of the parsing.
> The fix is to also use the auth.offset() and auth.length() parameters when building the
ByteBuffer.  Patch coming.

This message was sent by Atlassian JIRA

View raw message