accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey (JIRA)" <j...@apache.org>
Subject [jira] [Created] (ACCUMULO-1984) Clean up Instance closing
Date Sat, 07 Dec 2013 20:16:35 GMT
Sean Busbey created ACCUMULO-1984:
-------------------------------------

             Summary: Clean up Instance closing
                 Key: ACCUMULO-1984
                 URL: https://issues.apache.org/jira/browse/ACCUMULO-1984
             Project: Accumulo
          Issue Type: Improvement
    Affects Versions: 1.4.5, 1.5.1, 1.6.0
            Reporter: Sean Busbey
            Priority: Blocker
             Fix For: 1.4.5, 1.5.1, 1.6.0


Per discussion with [~ctubbsii] on ACCUMULO-1889:

{quote}
It seems to me that the best fix is to:
* patch org.apache.accumulo.fate.zookeeper.ZooReader.close() to handle the ZooKeeper close()'s
InterruptedException properly with Thread.currentThread().interrupt()
* stop propagating InterruptedException through the hierarchy of close() statements
* drop the AccumuloException from the Instance.close() method signature and make Interface
extend java.io.Closeable instead (at the very least, drop the unnecessary AccumuloException
and make it AutoCloseable when we switch to JDK1.7; changing it to java.io.Closeable now would
ease that)
change that catch statement to catch RuntimeExceptions instead of InterruptedException and
rethrow them after fixing the counter
{quote}

Since this API is just being added, we should fix these things now before it gets published
in a release.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message