accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-1984) Clean up Instance closing
Date Thu, 12 Dec 2013 16:27:09 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13846417#comment-13846417
] 

ASF subversion and git services commented on ACCUMULO-1984:
-----------------------------------------------------------

Commit 0d0bc4643a8680593e2cf5f828b7566c30fcb345 in branch refs/heads/1.5.1-SNAPSHOT from [~bhavanki]
[ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=0d0bc46 ]

ACCUMULO-1984 Rework interruption for instance implementations.

This change removes the throwing of InterruptedException from several
classes, simplifying the API. Some of the affected classes now also
implement java.io.Closeable.

Signed-off-by: Eric Newton <eric.newton@gmail.com>


> Clean up Instance closing
> -------------------------
>
>                 Key: ACCUMULO-1984
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-1984
>             Project: Accumulo
>          Issue Type: Improvement
>            Reporter: Sean Busbey
>            Assignee: Bill Havanki
>            Priority: Blocker
>             Fix For: 1.4.5, 1.5.1, 1.6.0
>
>         Attachments: ACCUMULO-1984-1.4.patch
>
>
> Per discussion with [~ctubbsii] on ACCUMULO-1889:
> {quote}
> It seems to me that the best fix is to:
> * patch org.apache.accumulo.fate.zookeeper.ZooReader.close() to handle the ZooKeeper
close()'s InterruptedException properly with Thread.currentThread().interrupt()
> * stop propagating InterruptedException through the hierarchy of close() statements
> * drop the AccumuloException from the Instance.close() method signature and make Interface
extend java.io.Closeable instead (at the very least, drop the unnecessary AccumuloException
and make it AutoCloseable when we switch to JDK1.7; changing it to java.io.Closeable now would
ease that)
> * change that catch statement to catch RuntimeExceptions instead of InterruptedException
and rethrow them after fixing the counter
> {quote}
> Since this API is just being added, we should fix these things now before it gets published
in a release.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Mime
View raw message