accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-1984) Clean up Instance closing
Date Wed, 11 Dec 2013 23:45:08 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13845854#comment-13845854
] 

Sean Busbey commented on ACCUMULO-1984:
---------------------------------------

The important bit, for me, is that everyplace we added a close() method in ACCUMULO-1379 and
ACCUMULO-1858 properly have the method signature for Closeable so that we aren't stuck once
those api changes go live in the next release cycles.

[~bhavanki], AFAIK, yes the close statements called starting at the ZKI.close

> Clean up Instance closing
> -------------------------
>
>                 Key: ACCUMULO-1984
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-1984
>             Project: Accumulo
>          Issue Type: Improvement
>            Reporter: Sean Busbey
>            Assignee: Bill Havanki
>            Priority: Blocker
>             Fix For: 1.4.5, 1.5.1, 1.6.0
>
>         Attachments: ACCUMULO-1984-1.4.patch
>
>
> Per discussion with [~ctubbsii] on ACCUMULO-1889:
> {quote}
> It seems to me that the best fix is to:
> * patch org.apache.accumulo.fate.zookeeper.ZooReader.close() to handle the ZooKeeper
close()'s InterruptedException properly with Thread.currentThread().interrupt()
> * stop propagating InterruptedException through the hierarchy of close() statements
> * drop the AccumuloException from the Instance.close() method signature and make Interface
extend java.io.Closeable instead (at the very least, drop the unnecessary AccumuloException
and make it AutoCloseable when we switch to JDK1.7; changing it to java.io.Closeable now would
ease that)
> * change that catch statement to catch RuntimeExceptions instead of InterruptedException
and rethrow them after fixing the counter
> {quote}
> Since this API is just being added, we should fix these things now before it gets published
in a release.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Mime
View raw message