accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-1965) Invalid table names (& namespaces) should have dedicated error codes
Date Thu, 05 Dec 2013 18:06:36 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-1965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13840350#comment-13840350
] 

Sean Busbey commented on ACCUMULO-1965:
---------------------------------------

bq. Then, if they still fail, it could be an illegal argument exception or a typed exception
(but never just a runtime exception) . And an illegal argument exception should be fine because
that's the only real argument to create table.

I agree that it should be an IllegalArgumentException.

bq. but it seems like we should have a table name check utility available to users in the
client api.

AFAICT, we all agree on this point. How about going with a static method on TableOperationsHelper?

As an aside, do we have table name restrictions documented somewhere?  Other than Constants.VALID_TABLE_REGEX,
I don't see anything and that's not in the public API. Namespaces have a note in the javadocs
for the create method on NamespaceOperations.

> Invalid table names (& namespaces) should have dedicated error codes
> --------------------------------------------------------------------
>
>                 Key: ACCUMULO-1965
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-1965
>             Project: Accumulo
>          Issue Type: Bug
>          Components: client
>            Reporter: John Vines
>
> To improve the client API, we should minimize the number of exceptions that require String
parsing to determine the exception type. Table naming errors is one of them.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message