accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-1947) dfs.datanode.synconclose check is lacking
Date Mon, 02 Dec 2013 22:54:36 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13837042#comment-13837042
] 

ASF subversion and git services commented on ACCUMULO-1947:
-----------------------------------------------------------

Commit cd96f85e0ec24be01d38c3a3dc78380f3b945d0b in branch refs/heads/1.6.0-SNAPSHOT from [~elserj]
[ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=cd96f85 ]

ACCUMULO-1947 Use DfsConfigKeys.DFS_DATANODE_SYNCONCLOSE_KEY instead of the CreateFlag class
as a better way to check
whether or not to we warn if the configuration doesn't contain dfs.datanode.synconclose=true


> dfs.datanode.synconclose check is lacking
> -----------------------------------------
>
>                 Key: ACCUMULO-1947
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-1947
>             Project: Accumulo
>          Issue Type: Bug
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>            Priority: Blocker
>             Fix For: 1.5.1, 1.6.0
>
>
> The dfs configuration checks we now perform to support hdfs WALs includes a check for
dfs.datanode.synconclose which informs the datanode to flush to disk when a file is closed
instead of lazily writing the block (very important in the case of power failure).
> Looking at the actual check, it performs reflection on a CreateFlag class. In Apache
Hadoop 1.2.1, this class doesn't exist yet the option for dfs.datanode.synconclose does exist.
We should likely just reflect on the constant DFSConfigKeys.DFS_DATANODE_SYNCONCLOSE_KEY or
DFSConfigKeys.DFS_DATANODE_SYNCONCLOSE_DEFAULT to determine if that option is present.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message