accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mike Drob (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-1910) Add source to jar files used for testing
Date Mon, 23 Dec 2013 20:34:52 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13855915#comment-13855915
] 

Mike Drob commented on ACCUMULO-1910:
-------------------------------------

Yea... I think we're making this complicated for the sake of preserving compatibility in something
that isn't part of the public API anyway. I strongly encourage the shortest path solution
here, as the code was never _functionally_ wrong, just a slight bit opaque. Like [~elserj]
alluded to earlier, a binary patch of swapping out one jar for another would likely have been
sufficient.

I added {{src/test-jars-src}} as another module to the main {{pom.xml}} and then saw the artifacts
get built.

I think it would be easiest for new users to grok fewer jars, since the source files will
exist in the tree anyway, but feel free to disagree. My main concern at this point is making
sure that the jars we are generating are the ones getting used by our tests, which I'm not
convinced is the case right now.

Can you create a new JIRA for the doc-gen issues that you are running into?

> Add source to jar files used for testing
> ----------------------------------------
>
>                 Key: ACCUMULO-1910
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-1910
>             Project: Accumulo
>          Issue Type: Task
>          Components: test
>    Affects Versions: 1.4.4, 1.5.0
>            Reporter: Josh Elser
>            Assignee: Ed Coleman
>              Labels: newbie
>             Fix For: 1.4.5, 1.5.1, 1.6.0
>
>         Attachments: ACCUMULO-1910-1.4.5.patch
>
>
> Some of the jars we include for testing purposes have the source included. Some do not.
> It would be nice to make sure that we included the source for all of these jars, not
just the class files.
> Jars in 1.4 with no source
> * ./src/start/src/test/resources/ClassLoaderTestA/Test.jar
> * ./src/start/src/test/resources/ClassLoaderTestB/Test.jar
> * ./src/start/src/test/resources/ClassLoaderTestC/Test.jar
> * ./src/start/target/test-classes/ClassLoaderTestA/Test.jar
> * ./src/start/target/test-classes/ClassLoaderTestB/Test.jar
> * ./src/start/target/test-classes/ClassLoaderTestC/Test.jar
> * ./test/system/auto/TestCombinerX.jar
> * ./test/system/auto/TestCombinerY.jar
> Jars in 1.5 and 1.6 with no source:
> * ./start/src/test/resources/ClassLoaderTestA/Test.jar
> * ./start/src/test/resources/ClassLoaderTestB/Test.jar
> * ./start/src/test/resources/ClassLoaderTestC/Test.jar
> * ./start/src/test/resources/HelloWorld2.jar
> * ./test/src/test/resources/FooConstraint.jar
> * ./test/system/auto/TestCombinerX.jar
> * ./test/system/auto/TestCombinerY.jar



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message