accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mike Drob (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-1910) Add source to jar files used for testing
Date Mon, 23 Dec 2013 19:25:50 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13855869#comment-13855869
] 

Mike Drob commented on ACCUMULO-1910:
-------------------------------------

When you say that the project version is set to 1.4.4, do you mean that the dependency version
is set to 1.4.4? Because I don't see anything else that it might be. It looks like it compiled
cleanly for me as applied, so I'm not really sure what the problem that you're describing
is.

After applying the patch and running {{mvn clean package}}, I spot checked {{./src/start/src/test/resources/ClassLoaderTestA/Test.jar}}
and {{./src/start/target/test-classes/ClassLoaderTestA/Test.jar}}, and neither one had source.
Should I have used a different maven goal to make it work?

Minor nit: there is trailing white space in some of the files: {{Test.java}}, {{TestObject.java}},
and some (but not all) of the {{pom.xml}}.

> Add source to jar files used for testing
> ----------------------------------------
>
>                 Key: ACCUMULO-1910
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-1910
>             Project: Accumulo
>          Issue Type: Task
>          Components: test
>    Affects Versions: 1.4.4, 1.5.0
>            Reporter: Josh Elser
>            Assignee: Ed Coleman
>              Labels: newbie
>             Fix For: 1.4.5, 1.5.1, 1.6.0
>
>         Attachments: ACCUMULO-1910-1.4.5.patch
>
>
> Some of the jars we include for testing purposes have the source included. Some do not.
> It would be nice to make sure that we included the source for all of these jars, not
just the class files.
> Jars in 1.4 with no source
> * ./src/start/src/test/resources/ClassLoaderTestA/Test.jar
> * ./src/start/src/test/resources/ClassLoaderTestB/Test.jar
> * ./src/start/src/test/resources/ClassLoaderTestC/Test.jar
> * ./src/start/target/test-classes/ClassLoaderTestA/Test.jar
> * ./src/start/target/test-classes/ClassLoaderTestB/Test.jar
> * ./src/start/target/test-classes/ClassLoaderTestC/Test.jar
> * ./test/system/auto/TestCombinerX.jar
> * ./test/system/auto/TestCombinerY.jar
> Jars in 1.5 and 1.6 with no source:
> * ./start/src/test/resources/ClassLoaderTestA/Test.jar
> * ./start/src/test/resources/ClassLoaderTestB/Test.jar
> * ./start/src/test/resources/ClassLoaderTestC/Test.jar
> * ./start/src/test/resources/HelloWorld2.jar
> * ./test/src/test/resources/FooConstraint.jar
> * ./test/system/auto/TestCombinerX.jar
> * ./test/system/auto/TestCombinerY.jar



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message