Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: jira@apache.org
Date: Tue, 26 Nov 2013 03:27:36 +0000 (UTC)
From: "Josh Elser (JIRA)" <jira@apache.org>
To: notifications@accumulo.apache.org
Message-ID: <JIRA.12680364.1384978824170.28709.1385436456383@arcas>
In-Reply-To: <JIRA.12680364.1384978824170@arcas>
References: <JIRA.12680364.1384978824170@arcas>
Subject: [jira] [Commented] (ACCUMULO-1910) Add source to jar files used for
 testing
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/ACCUMULO-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13832270#comment-13832270 ] 

Josh Elser commented on ACCUMULO-1910:
--------------------------------------

bq. Because this is a classloader test, was this created as a separate project so that it would not be in the accumulo namespace and is that how it went missing? 

I'd have to look at the test cases that load these jars, but I don't think they were in their own namespace. I don't think we need to have anything in our source tree for them, but having the source files in the jar with the class file would be nice, IMO. So, a new jar for those which have no source is what I was thinking of. You could attach either the source Java files or a new jar (which contains the source). It's up to you.

My gut reaction was that we need source (per ASF policy), but [~billie.rinaldi] pointed out on the mailing list that she doesn't think that to be the case. Regardless, it would be nice for people trying to understand this code to have access to all the source we use to test.

> Add source to jar files used for testing
> ----------------------------------------
>
>                 Key: ACCUMULO-1910
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-1910
>             Project: Accumulo
>          Issue Type: Task
>          Components: test
>    Affects Versions: 1.4.4, 1.5.0
>            Reporter: Josh Elser
>              Labels: newbie
>             Fix For: 1.4.5, 1.5.1, 1.6.0
>
>
> Some of the jars we include for testing purposes have the source included. Some do not.
> It would be nice to make sure that we included the source for all of these jars, not just the class files.
> Jars in 1.4 with no source
> * ./src/start/src/test/resources/ClassLoaderTestA/Test.jar
> * ./src/start/src/test/resources/ClassLoaderTestB/Test.jar
> * ./src/start/src/test/resources/ClassLoaderTestC/Test.jar
> * ./src/start/target/test-classes/ClassLoaderTestA/Test.jar
> * ./src/start/target/test-classes/ClassLoaderTestB/Test.jar
> * ./src/start/target/test-classes/ClassLoaderTestC/Test.jar
> * ./test/system/auto/TestCombinerX.jar
> * ./test/system/auto/TestCombinerY.jar
> Jars in 1.5 and 1.6 with no source:
> * ./start/src/test/resources/ClassLoaderTestA/Test.jar
> * ./start/src/test/resources/ClassLoaderTestB/Test.jar
> * ./start/src/test/resources/ClassLoaderTestC/Test.jar
> * ./start/src/test/resources/HelloWorld2.jar
> * ./test/src/test/resources/FooConstraint.jar
> * ./test/system/auto/TestCombinerX.jar
> * ./test/system/auto/TestCombinerY.jar


--
This message was sent by Atlassian JIRA
(v6.1#6144)