accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Terry Porter (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-1901) start-here.sh starts only one GC process even if more are defined
Date Sun, 17 Nov 2013 20:15:21 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13824942#comment-13824942
] 

Terry Porter commented on ACCUMULO-1901:
----------------------------------------

Thanks Sean. I'm a newbie with git, so I want to ensure I do the commit step properly. My
questions are:

1. 'git help commit' says "even modified files must be 'added'" but the Accumulo Contributor
instructions don't mention doing a 'git add' at all.  Do I need to first to a 'git add' for
the filename I'm changing / going to change?

2. Step 5 "Make commits" mentions "referencing the issue name in the commit message", but
the syntax shown doesn't include the -m switch that I see in the git commit help.  I assume
a more complete syntax example for my case would be:

git commit -av -m "ACCUMULO-1901" bin/start-here.sh

Or if I do it from the directory where my code change was done, do I even need to include
the filename? Or ever? (meaning does git commit everything in its index automatically?)  Again,
I'm brand new to git and want to do this right the first time.

Thanks for the help!

> start-here.sh starts only one GC process even if more are defined
> -----------------------------------------------------------------
>
>                 Key: ACCUMULO-1901
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-1901
>             Project: Accumulo
>          Issue Type: Bug
>          Components: gc, scripts
>    Affects Versions: 1.4.2, 1.4.3, 1.4.4, 1.5.0
>         Environment: Red Hat Enterprise Linux 6.3 64-bit
>            Reporter: Terry Porter
>            Priority: Minor
>              Labels: newbie
>             Fix For: 1.4.5, 1.5.1, 1.6.0
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Even when a second host is listed in the gc file, the gc process is only ever started
on the first host listed in the gc file.  The issue lies in lines 48-55 in start-here.sh as
shown below:
> {code}
> for host in $HOSTS
> do
>     if [ ${host} = ${GC} ]
>     then
>         ${bin}/start-server.sh $GC gc "garbage collector"
>         break
>     fi
> done
> {code}
> Simple fix:
> {code}
> for host in $HOSTS
> do
>     if grep -q "^${host}\$" $ACCUMULO_HOME/conf/gc
>     then
>         ${bin}/start-server.sh ${host} gc "garbage collector"
>         break
>     fi
> done
> {code}
> This fix works in my 1.4.2 environment.  stop-here.sh already sweeps all possible processes
to kill them, so no fix needed there.
> I posted the fix in case anyone needs this ASAP as this will be my first development
work with an open source project, but I hope to be able to post the fix this weekend.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message