accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christopher Tubbs (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-1675) Accumulo maven plugin should not run when skipTests is set
Date Mon, 04 Nov 2013 18:34:19 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13813090#comment-13813090
] 

Christopher Tubbs commented on ACCUMULO-1675:
---------------------------------------------

The reason this isn't a bug, is because the accumulo-maven-plugin does one thing: runs an
instance of Accumulo during the build. While written to make it easier to do testing, it does
not *have* to be used for testing, it is not intrinsically tied to testing, and it is non-intuitive
to assume that it will deactivate when tests are skipped. It simply runs when it is defined
in the POM to do so.

If required, it is entirely possible for a user to define it in a profile that is deactivated
with a skipTests property, or (perhaps more appropriate, given the default binding) a skipITs
property.

It should be pointed out that there's nothing magical about the "skipTests" property in Maven.
It is a property that just so happens to trigger specific behavior in a few plugins (namely,
maven-surefire-plugin and maven-failsafe-plugin). This plugin was designed to execute at the
pre-integration-test phase, but it does not have to, and it should not be assumed that the
maven-failsafe-plugin, which does respond to the skipTests property, will be used with this
plugin. It should also not be assumed that the appearance of skipTests property is an instruction
for this plugin... because it is well-known property of another plugin entirely.

However, all that said, it is a normal thing to deactivate the execution of a plugin under
several different conditions, and to enable that, I think that the best route is not to have
it respect skipTests, but instead, it should have its own skip property (accumulo.skip?),
which can be set with any of several build profiles that a user wishes to configure.


> Accumulo maven plugin should not run when skipTests is set
> ----------------------------------------------------------
>
>                 Key: ACCUMULO-1675
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-1675
>             Project: Accumulo
>          Issue Type: Bug
>          Components: maven-plugin
>    Affects Versions: 1.6.0
>            Reporter: Keith Turner
>             Fix For: 1.6.1
>
>
> I am using the accumulo-maven-plugin to test an Accumulo project I am working on.  When
I run "mvn install -DskipTests" it starts and stops mini accumulo.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message