Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: jira@apache.org
Date: Wed, 9 Oct 2013 20:26:46 +0000 (UTC)
From: "Christopher Tubbs (JIRA)" <jira@apache.org>
To: notifications@accumulo.apache.org
Message-ID: <JIRA.12672670.1381170748146.40919.1381350406107@arcas>
In-Reply-To: <JIRA.12672670.1381170748146@arcas>
References: <JIRA.12672670.1381170748146@arcas>
Subject: [jira] [Commented] (ACCUMULO-1757) Create BatchDeleter with a
 provided BatchWriter instead of creating a new one
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/ACCUMULO-1757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13790827#comment-13790827 ] 

Christopher Tubbs commented on ACCUMULO-1757:
---------------------------------------------

{quote}BatchReaders really aren't made to be reused the way BatchWriters are. BatchReaders are destructive when they get repurposed.{quote}

I'd hate for the API decision to be based on the subtleties of internal implementation, like the fact that BatchReaders and BatchWriters use threads differently. I like the idea of passing a ThreadPool as an option to createBatchDeleter and createBatchWriter. It's much more intuitive, and it can be easily added to BatchWriterConfig without mucking about with the main factory API.

Alternatively, BatchWriter could extend BatchWriterConfig (and delegate the methods to its internal bwconfig field). BatchDeleter can check the type of the parameter and reuse it if it happens to be a BatchWriter. But, I like the ThreadPool parameter better.


> Create BatchDeleter with a provided BatchWriter instead of creating a new one
> -----------------------------------------------------------------------------
>
>                 Key: ACCUMULO-1757
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-1757
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: client
>            Reporter: John Vines
>            Priority: Minor
>             Fix For: 1.6.0
>
>
> For the BatchDeleter, you pass it all the configs you need to create both a Scanner and a BatchWriter for it to provide really convenient deletes. However, if a client already has a BatchWriter, it would be convenient to just hand it an existing BatchWriter to use instead of creating a separate one.


--
This message was sent by Atlassian JIRA
(v6.1#6144)