accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Vines (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-1757) Create BatchDeleter with a provided BatchWriter instead of creating a new one
Date Mon, 07 Oct 2013 22:39:41 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-1757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13788657#comment-13788657
] 

John Vines commented on ACCUMULO-1757:
--------------------------------------

BatchReaders really aren't made to be reused the way BatchWriters are. BatchReaders are destructive
when they get repurposed. But I guess I could see it being passed in as an option though.


Passing in a threadpool only works if you can hand it the BatchWriter threadpool in a safe
manor, as well as the heap management. I mean, batchwriter itself makes a lot of sense because
it already does all the binning and everything and there are expectations that the BatchWriter
itself manages the threadpools and memory, etc. so it seems like extracting that part out
would be painful.

> Create BatchDeleter with a provided BatchWriter instead of creating a new one
> -----------------------------------------------------------------------------
>
>                 Key: ACCUMULO-1757
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-1757
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: client
>            Reporter: John Vines
>            Priority: Minor
>             Fix For: 1.6.0
>
>
> For the BatchDeleter, you pass it all the configs you need to create both a Scanner and
a BatchWriter for it to provide really convenient deletes. However, if a client already has
a BatchWriter, it would be convenient to just hand it an existing BatchWriter to use instead
of creating a separate one.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message